Update logging for task hub NotFound #413
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the logging for when a task hub connection returns NotFound. Previously it was logged as an unknown error, it is now a warn. Signed-off-by: halspang <[email protected]>
halspang
force-pushed
the
halspang/taskhub_notfound_logging
branch
from
6a5b0dd to
6964e90
Compare
cgillum
reviewed
Apr 18, 2025
| } | ||
| catch (RpcException ex) when (ex.StatusCode == StatusCode.NotFound) | ||
| { | ||
| // Task hub is not found or insufficient permissions - retry |
Member
There was a problem hiding this comment.
Typically, 404 Not Found responses are not supposed to be retried. Why would we want to retry in our case?
Member
Author
There was a problem hiding this comment.
The two main reasons I had for this were:
- A 404 is returned from the scheduler if the task hub isn't present or if there are insufficient permissions to access it. Given permissions can take time to propagate, I didn't want to have the customer have to go in and restart their worker to get things working again.
- A scheduler and a task hub can be deployed in separate steps of a deployment. If the worker is mistakenly put in between them, it would mean the customer has to restart their worker again to get things going.
- It's the behavior today (since we retry on unknown) and stopping that may be a breaking change. Who knows what customers depend on so I changed it to at least highlight the log better.
Let me know if you think those are valid reasons or if you think we should change the behavior or add additional sleeping.
Member
There was a problem hiding this comment.
Sounds good to me! Might be worth mentioning this in the comments. (thought this particular code path is agnostic to DTS, so ideally you'd explain it in a more agnostic way :))
cgillum
approved these changes
Apr 18, 2025
Signed-off-by: halspang <[email protected]>
cgillum
approved these changes
Apr 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the logging for when a task hub connection returns NotFound. Previously it was logged as an unknown error, it is now a warn.